Adding snap classic confinement support#1200
Merged
SableRaf merged 1 commit intoprocessing:mainfrom Aug 14, 2025
Merged
Conversation
Stefterv
force-pushed
the
snap-classic-support
branch
from
9f4de54 to
bccf99b
Compare
Stefterv
force-pushed
the
snap-classic-support
branch
from
bccf99b to
eece777
Compare
catilac
approved these changes
Aug 12, 2025
Collaborator
catilac
left a comment
catilac
left a comment
There was a problem hiding this comment.
This LGTM. I left one comment, but it's up to you if you want to address it. Generally, I like to ask questions mostly out of curiosity :)
Comment on lines
+256
to
+265
| if (confinement != "classic") return@let it | ||
| // If confinement is not strict, remove the PLUGS section | ||
| val start = it.indexOf("# PLUGS START") | ||
| val end = it.indexOf("# PLUGS END") | ||
| if (start != -1 && end != -1) { | ||
| val before = it.substring(0, start) | ||
| val after = it.substring(end + "# PLUGS END".length) | ||
| return@let before + after | ||
| } | ||
| return@let it |
Collaborator
There was a problem hiding this comment.
could this be moved into a helper function?
Collaborator
Author
There was a problem hiding this comment.
Sure, but it is only being used once, which means it would clutter up the file and be less clear where it is being used
1 task
SableRaf
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1186
Fixes #1147
Fixes #1119
Fixes #995